Skip to content

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Nov 4, 2019

This is mostly a rebase and clean-up of #136 that allows running the test for SwiftSyntax on Linux.

It also renames test files to have consistent common suffix which is Tests.

@ahoppen ahoppen requested a review from nkcsgexi November 4, 2019 23:14
@ahoppen
Copy link
Member Author

ahoppen commented Nov 5, 2019

@swift-ci Please test

We can thus remove the allTests properties and LinuxMain.swift
@ahoppen
Copy link
Member Author

ahoppen commented Nov 6, 2019

I have updated this PR to use --enable-test-discovery instead of the generated LinuxMain.swift.

I am waiting for swiftlang/swift-package-manager#2400 and swiftlang/swift-package-manager#2401 to merge before we can land this.

@ahoppen ahoppen requested a review from akyrtzi November 6, 2019 23:45
Copy link
Contributor

@akyrtzi akyrtzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ahoppen
Copy link
Member Author

ahoppen commented Nov 7, 2019

@swift-ci Please test

@swiftlang swiftlang deleted a comment from swift-ci Nov 7, 2019
@ahoppen ahoppen merged commit 77d4d4c into swiftlang:master Nov 7, 2019
@ahoppen ahoppen deleted the linux branch November 7, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants